Update demo to connect with MPI #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzmanvig
reviewed
Jun 24, 2024
| @@ -17,6 +17,9 @@ const Header = ({ selection, showSelectionMeta, toggleShowSelectionMeta, toggleS | |||
| showSelectionMeta={showSelectionMeta} | |||
| toggleShowSelectionMeta={toggleShowSelectionMeta} | |||
| /> | |||
| <ExportToMPI | |||
| sendToMPI={sendToMPI} | |||
There was a problem hiding this comment.
nit: why passing this as a prop instead of just declaring the function here?
| @@ -441,3 +483,25 @@ const SidebarFooter = () => ( | |||
| </p> | |||
| </div> | |||
| ); | |||
|
|
|||
| const Alert = ({ visible, positive }) => { | |||
| if (visible) { | |||
There was a problem hiding this comment.
If not visible doesn't return anything? If so, maybe we can remove the prop and do:
this.state.message.visible && <Alert positive={this.state.message.positive} />
| if (visible) { | ||
| if (positive) { | ||
| return ( | ||
| <Message id="alert-message" positive> |
There was a problem hiding this comment.
nit: a version that uses less code could be something like:
<Message id="alert-message" positive={positive} negative={!positive}>
<p>
{ positive ? "Sequence successfully exported to MPI." : "Error exporting sequence to MPI. Try again later".
</p>
</Message>
chris-krenz
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.